Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Changelog and add upper bounds #5

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

pmiddend
Copy link
Collaborator

@pmiddend pmiddend commented Aug 2, 2024

No description provided.

@pmiddend pmiddend force-pushed the pre-release-fixes branch from 7deefcc to 66904fd Compare August 2, 2024 06:33
@pmiddend
Copy link
Collaborator Author

pmiddend commented Aug 2, 2024

@picca I've added upper version bounds. Not sure if they're good, but they seem to be sort of mandatory (Hackage might not accept packages without them in the future).

Seem fine to you? Then we can merge and release.

@picca picca merged commit 9ea7dc0 into picca:master Aug 2, 2024
@pmiddend pmiddend deleted the pre-release-fixes branch August 2, 2024 07:42
@picca
Copy link
Owner

picca commented Aug 2, 2024 via email

@pmiddend
Copy link
Collaborator Author

pmiddend commented Aug 2, 2024

done :)) https://hackage.haskell.org/package/hdf5-1.8.12 thanks a lot Fred

Very nice, thank you!

@picca
Copy link
Owner

picca commented Aug 2, 2024 via email

@picca
Copy link
Owner

picca commented Aug 4, 2024 via email

@picca
Copy link
Owner

picca commented Aug 4, 2024 via email

@pmiddend
Copy link
Collaborator Author

pmiddend commented Aug 5, 2024

Interesting. I'm not sure why the Haskell library tries to add this symbol. H5S.hsc says:

#if HDF5get_info_vers == 1
#ccall H5Sencode, <hid_t> -> OutArray CChar -> InOut <size_t> -> IO <herr_t>
#else
#ccall H5Sencode2, <hid_t> -> OutArray CChar -> InOut <size_t> -> IO <herr_t>

h5s_encode :: HId_t -> OutArray CChar -> InOut CSize -> IO HErr_t
h5s_encode = h5s_encode2
#endif

@picca
Copy link
Owner

picca commented Aug 5, 2024 via email

@pmiddend
Copy link
Collaborator Author

pmiddend commented Aug 5, 2024

I'm not sure I'm following. You can only expose/export functions that are actually there, as far as I know. So we have to have ifdefs.

@picca
Copy link
Owner

picca commented Aug 5, 2024 via email

@picca
Copy link
Owner

picca commented Aug 6, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants